Skip to content

Add message when missing nested screen's screen#5068

Merged
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-7247
Aug 1, 2023
Merged

Add message when missing nested screen's screen#5068
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-7247

Conversation

@marcoAntonioNina
Copy link
Copy Markdown
Contributor

@marcoAntonioNina marcoAntonioNina commented Jul 31, 2023

Issue & Reproduction Steps

In the file to import not exists a screen, this screen refers to a nested screen.

Solution

  • Add validation when the reference of the NestedSscreen's screen not exists.
  • add a log message

How to Test

Import process and review the message, the process was imported but without a screen reference
image

Related Tickets & Packages

FOUR-7247

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-4db471a683.eng.processmaker.net

@runyan-co runyan-co self-requested a review August 1, 2023 16:17
Copy link
Copy Markdown
Contributor

@runyan-co runyan-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, good job @marcoAntonioNina!

@ryancooley ryancooley merged commit d419108 into develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants